Basic Assignments
Options & Settings
Main Time Information
Color Code: Orange
Assigned To: JM Developments LLC
Created By: JM Developments LLC
Created Date/Time: 9/26/2022 11:17 am
Action Status: Blank (new)
Show On The Web: Yes - (public)
Priority: 0
Time Id: 9413
Template/Type: Brandon Time
Title/Caption: Code Review
Start Date/Time: 9/29/2022 10:15 am
End Date/Time: 9/29/2022 12:30 pm
Main Status: Active

Sorry, no photos available for this element of time.


Meeting with John and Cory to do a code review on the discount engine project. John started out by talking about a class that he is taking at school and a section called "Requirements Engineering". He is going to pass on some information to both Cory and I. One of the main goals or strategies of that requirements engineering is being able to see and quantify those requirements.

We talked briefly about taking the time to get it right vs having to go back (again and again) to do other maintenance or backing to back track. I agree with that, however, there are times that you just need to get it done and you know that you will have to circle back around and fill in the gaps. There is not just one answer for every possible solution.

Most of the meeting was a code review session. John walked us through the process and did a great job verbally walking us through his code. If we had questions, he would take and show us on the discount engine why, what, and how he was doing certain things. I thought that he did a great job explaining his code. We made a few recommendations, but mostly it was him telling us and showing us what he has been working on. He is getting really close and is starting to work on the action page to really get the stuff to stick in the database. The frontend interface looks great.

We got into caching of objects, memory usage, and memory management topics. We spent quite a bit of time going over custom JavaScript that he had to set up to make his little one-pager work. One of the interesting things that he and Wayne are coming up with deals with using the users to help run the database updates based on automation processes and usage within the system. Most of John's new code is all in script vs the older ColdFusion tag based language. He likes that style way more and it feels like other languages that he knows.

The last topic of the joint meeting between Cory, John, and I was dealing with team building and getting enough training to help us all do our jobs and help spread the love, dealing with knowledge and training. After Cory left, John had a few other questions about finances and checking on the health of the business. Great meeting!